Skip to content

Clarify differential pair ambiguity warnings - #3017

Merged
0hmX merged 2 commits into
mainfrom
agent/clarify-differential-pair-ambiguity
Aug 5, 2026
Merged

Clarify differential pair ambiguity warnings#3017
0hmX merged 2 commits into
mainfrom
agent/clarify-differential-pair-ambiguity

Conversation

@0hmX

@0hmX 0hmX commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #3011.

What changed

  • Report a named differential-pair trace with more than two terminal pins as an ambiguous trace name.
  • Include the pair, connection property, trace name, and complete terminal-pin list.
  • Report selector and incomplete-connection failures factually as expected exactly 2 terminal pins, found N.
  • Remove all advice to delete connections or switch to a pin selector.
  • Remove the unnecessary singular/plural message construction.

Why

Core does not ignore or rewrite the differential-pair connection. The diagnostic should state the topology problem without prescribing a circuit or selector change. A named trace is ambiguous when its resolved connection contains more than two terminal pins; other invalid counts are simply not point-to-point.

Developer impact

Users receive concise, non-prescriptive diagnostics that identify the actual connection problem and list the affected pins.

Validation

  • Focused differential-pair warning tests: 3 passing, 10 assertions
  • bunx tsc --noEmit
  • Biome checks on all changed files
  • git diff --check
  • Three independent review passes covering wording, edge cases, and minimal-diff quality

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 5, 2026 11:02am

Request Review

@0hmX
0hmX marked this pull request as ready for review August 5, 2026 11:04
@0hmX
0hmX merged commit c35a4ff into main Aug 5, 2026
16 checks passed
@0hmX
0hmX deleted the agent/clarify-differential-pair-ambiguity branch August 5, 2026 11:05
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants